-
Notifications
You must be signed in to change notification settings - Fork 874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update .pre-commit-config to match linting used by CI #1906
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
@scanny Though the initial trailing commas aren't registering as an issue, I am getting the following commas added (these are new):
|
@Coniferish hmm, that's odd, let me take a look. Are those being added locally by the pre-commit hook? Those aren't by themselves problematic because they don't increase the line count, but they don't happen on my machine and CI doesn't complain about it. Can you tell if those are added by |
That looks like |
Could you also add the ignores to the |
@scanny Yah, looks like they were. My mistake. |
@qued Please look at the changes I pushed--I added a couple of things the to |
Closes #1905
.pre-commit-config.yaml does not match pyproject.toml, which causes unnecessary/undesirable formatting changes. These changes are not required by CI, so they should not have to be made.
To Reproduce
Install pre-commit configuration as described here. Make a commit and something like the following will be logged: