fix documentation for chroma #2403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 16, 2024 09:07
Comment on lines
30
to
38
| required=False, | ||
| default="default_tenant", | ||
| required=True, | ||
| type=str, | ||
| help="The tenant to use for this client.", | ||
| help="The tenant to use for this client." "Chroma default is 'default_tenant'.", | ||
| ), | ||
| click.Option( | ||
| ["--database"], | ||
| required=False, | ||
| default="default_database", | ||
| required=True, | ||
| type=str, | ||
| help="The database to use for this client.", | ||
| help="The database to use for this client." "Chroma default is 'default_database'.", |
There was a problem hiding this comment.
sorry, circling back from DMs. did not realize Chroma actually defaults to these values itself. in which case this is fine! ...maybe add a comment somewhere to that extent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test:
cd docs && make HTML
changelogs:
point main readme to the correct connector html page
point chroma docs to correct sample code