-
Notifications
You must be signed in to change notification settings - Fork 874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix documentation for chroma #2403
Conversation
required=False, | ||
default="default_tenant", | ||
required=True, | ||
type=str, | ||
help="The tenant to use for this client.", | ||
help="The tenant to use for this client." "Chroma default is 'default_tenant'.", | ||
), | ||
click.Option( | ||
["--database"], | ||
required=False, | ||
default="default_database", | ||
required=True, | ||
type=str, | ||
help="The database to use for this client.", | ||
help="The database to use for this client." "Chroma default is 'default_database'.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, circling back from DMs. did not realize Chroma actually defaults to these values itself. in which case this is fine! ...maybe add a comment somewhere to that extent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
To test:
cd docs && make HTML
changelogs:
point main readme to the correct connector html page
point chroma docs to correct sample code