Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix documentation for chroma #2403

Merged
merged 12 commits into from
Jan 17, 2024
Merged

fix documentation for chroma #2403

merged 12 commits into from
Jan 17, 2024

Conversation

potter-potter
Copy link
Contributor

To test:

cd docs && make HTML

changelogs:

point main readme to the correct connector html page
point chroma docs to correct sample code

Comment on lines 30 to 38
required=False,
default="default_tenant",
required=True,
type=str,
help="The tenant to use for this client.",
help="The tenant to use for this client." "Chroma default is 'default_tenant'.",
),
click.Option(
["--database"],
required=False,
default="default_database",
required=True,
type=str,
help="The database to use for this client.",
help="The database to use for this client." "Chroma default is 'default_database'.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, circling back from DMs. did not realize Chroma actually defaults to these values itself. in which case this is fine! ...maybe add a comment somewhere to that extent

Copy link
Contributor

@ryannikolaidis ryannikolaidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@potter-potter potter-potter added this pull request to the merge queue Jan 17, 2024
@potter-potter potter-potter removed this pull request from the merge queue due to a manual request Jan 17, 2024
@potter-potter potter-potter added this pull request to the merge queue Jan 17, 2024
Merged via the queue into main with commit d7f4c24 Jan 17, 2024
@potter-potter potter-potter deleted the potter/fix_chroma_doc branch January 17, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants