Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Rename dolphinscheduler-aop to dolphinscheduler-yarn-aop #16095

Merged
merged 1 commit into from
May 31, 2024

Conversation

ruanwenjun
Copy link
Member

Purpose of the pull request

  • The module name dolphinscheduler-aop is incurracy

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

SbloodyS
SbloodyS previously approved these changes May 31, 2024
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_renameYarnAop branch 2 times, most recently from 18ca520 to 1f1809b Compare May 31, 2024 01:33
@ruanwenjun
Copy link
Member Author

nimbus-jose-jwt already exist

nimbus-jose-jwt-9.8.1.jar
nimbus-jose-jwt-9.10.jar

todo: we need to unify the version

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_renameYarnAop branch from 1f1809b to 413d96e Compare May 31, 2024 01:54
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_renameYarnAop branch from 413d96e to e2a4381 Compare May 31, 2024 01:54
@codecov-commenter
Copy link

codecov-commenter commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.67%. Comparing base (d675c28) to head (26bddad).

Current head 26bddad differs from pull request most recent head e2a4381

Please upload reports for the commit e2a4381 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev   #16095   +/-   ##
=========================================
  Coverage     40.66%   40.67%           
- Complexity     5237     5238    +1     
=========================================
  Files          1382     1382           
  Lines         46024    46024           
  Branches       4922     4922           
=========================================
+ Hits          18716    18719    +3     
+ Misses        25382    25380    -2     
+ Partials       1926     1925    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

@ruanwenjun ruanwenjun requested review from Radeity and rickchengx May 31, 2024 03:31
@ruanwenjun ruanwenjun merged commit 3bc88e3 into apache:dev May 31, 2024
62 of 64 checks passed
@ruanwenjun ruanwenjun deleted the dev_wenjun_renameYarnAop branch May 31, 2024 09:12
@ruanwenjun ruanwenjun self-assigned this May 31, 2024
@ruanwenjun ruanwenjun added this to the 3.3.0 milestone May 31, 2024
@SbloodyS SbloodyS added the chore label Aug 30, 2024
@SbloodyS SbloodyS changed the title Rename dolphinscheduler-aop to dolphinscheduler-yarn-aop [Chore] Rename dolphinscheduler-aop to dolphinscheduler-yarn-aop Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants