Skip to content
This repository was archived by the owner on Oct 13, 2023. It is now read-only.

[18.06] backport select polling based watcher for Windows log watcher #34

Merged
merged 1 commit into from
Aug 16, 2018

Conversation

thaJeztah
Copy link
Member

cherry-pick of moby#37412 for 18.06
fixes moby#30046 for 18.06

git checkout -b 18.06-backport-logissue ce-engine/18.06
git cherry-pick -s -S -x df84cdd091631f32abaedd805791db89ac5c83d4
git push -u origin

cherry-pick was clean; no conflicts

Signed-off-by: Tejaswini Duggaraju <[email protected]>
(cherry picked from commit df84cdd)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah added this to the 18.06.1 milestone Aug 14, 2018
@andrewhsu andrewhsu requested a review from johnstep August 14, 2018 22:32
Copy link

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM wrt the cherry-pick operation

Copy link

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

@thaJeztah thaJeztah merged commit 320063a into docker-archive:18.06 Aug 16, 2018
@thaJeztah thaJeztah deleted the 18.06-backport-logissue branch August 16, 2018 08:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants