Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for docker intercepting DNS requests on ICS network #2014

Merged
merged 1 commit into from
Dec 7, 2017
Merged

Fix for docker intercepting DNS requests on ICS network #2014

merged 1 commit into from
Dec 7, 2017

Conversation

msabansal
Copy link
Contributor

New versions of Windows now ship with a default network which is of type ICS. This network supports its own DNS server. We found an issue where docker was intercepting requests on these networks.

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "icsdnsissue" [email protected]:msabansal/libnetwork.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@codecov-io
Copy link

codecov-io commented Nov 17, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@460ac8f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2014   +/-   ##
=========================================
  Coverage          ?   38.98%           
=========================================
  Files             ?      137           
  Lines             ?    27374           
  Branches          ?        0           
=========================================
  Hits              ?    10672           
  Misses            ?    15407           
  Partials          ?     1295

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 460ac8f...ba2de36. Read the comment docs.

@msabansal
Copy link
Contributor Author

@mavenugo PTAL. Lots of people are reporting this issue.

@pradipd
Copy link
Contributor

pradipd commented Dec 7, 2017

LGTM

@fcrisciani
Copy link

LGTM all green merging

@fcrisciani fcrisciani merged commit ea0db4f into moby:master Dec 7, 2017
fcrisciani pushed a commit to fcrisciani/docker that referenced this pull request Dec 14, 2017
Windows fixes:
moby/libnetwork#1916
moby/libnetwork#2014
moby/libnetwork#2021

Fix for veth leak on daemon crash
Cleanup networkDB logic for node management

Signed-off-by: Flavio Crisciani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants