Fix for docker intercepting DNS requests on ICS network #2014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please sign your commits following these rules: $ git clone -b "icsdnsissue" [email protected]:msabansal/libnetwork.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
Signed-off-by: Sandeep Bansal <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2014 +/- ##
=========================================
Coverage ? 38.98%
=========================================
Files ? 137
Lines ? 27374
Branches ? 0
=========================================
Hits ? 10672
Misses ? 15407
Partials ? 1295Continue to review full report at Codecov.
|
|
@mavenugo PTAL. Lots of people are reporting this issue. |
|
LGTM |
|
LGTM all green merging |
fcrisciani
pushed a commit
to fcrisciani/docker
that referenced
this pull request
Dec 14, 2017
Windows fixes: moby/libnetwork#1916 moby/libnetwork#2014 moby/libnetwork#2021 Fix for veth leak on daemon crash Cleanup networkDB logic for node management Signed-off-by: Flavio Crisciani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New versions of Windows now ship with a default network which is of type ICS. This network supports its own DNS server. We found an issue where docker was intercepting requests on these networks.