Added a new network creation driver option (disable_gatewaydns) for t…

[soccerGB]

…he Windows driver

Signed-off-by: Cheng-mean Liu [email protected]

This new disable_gatewaydns option provides a way for a client to create a network instance without any gateway IP added into the DNS list for all of its endpoints.

Usage of disable_gatewaydns:
When set as true, the Windows network driver will skip the addition of the gateway IP into the DNS list.
When not specified, the default setting for disable_gatewaydns is false, that is, it will always add gateway IP into an endpoint's DNS list unless an endpoint was created specifically with an existing epOption.DisableDNS option.

Example usage:
docker network create -d nat --gateway 172.8.128.1 --subnet 172.8.128.0/20 -o com.docker.network.windowsshim.dnsservers=4.4.4.4,8.8.8.8 -o com.docker.network.windowsshim.disable_gatewaydns=true mynat

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@460ac8f). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2021   +/-   ##
=========================================
  Coverage          ?   38.85%           
=========================================
  Files             ?      137           
  Lines             ?    27374           
  Branches          ?        0           
=========================================
  Hits              ?    10637           
  Misses            ?    15439           
  Partials          ?     1298

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 460ac8f...884eaa0. Read the comment docs.

[msabansal]

LGTM

[aserdean]

Thanks a lot for the patch!

It would be nice to mention this change require Windows version 1709 to work.

PS C:\> docker network create -d nat --gateway 172.8.128.1 --subnet 172.8.128.0/20 -o com.docker.network.windowsshim.dnsservers=4.4.4.4,8.8.8.8 -o com.docker.network.windowsshim.disable_gatewaydns=true mynat

PS C:\> docker run --network mynat microsoft/windowsservercore:1709 ipconfig /all

Windows IP Configuration

   Host Name . . . . . . . . . . . . : dce0a7aa7c75
   Primary Dns Suffix  . . . . . . . :
   Node Type . . . . . . . . . . . . : Hybrid
   IP Routing Enabled. . . . . . . . : No
   WINS Proxy Enabled. . . . . . . . : No
   DNS Suffix Search List. . . . . . : localdomain

Ethernet adapter vEthernet (Ethernet):

   Connection-specific DNS Suffix  . : localdomain
   Description . . . . . . . . . . . : Hyper-V Virtual Ethernet Adapter #5
   Physical Address. . . . . . . . . : 00-15-5D-BA-33-0B
   DHCP Enabled. . . . . . . . . . . : No
   Autoconfiguration Enabled . . . . : Yes
   Link-local IPv6 Address . . . . . : fe80::4c22:564:797d:206e%29(Preferred)
   IPv4 Address. . . . . . . . . . . : 172.8.130.38(Preferred)
   Subnet Mask . . . . . . . . . . . : 255.255.240.0
   Default Gateway . . . . . . . . . : 172.8.128.1
   DNS Servers . . . . . . . . . . . : 4.4.4.4
                                       8.8.8.8
   NetBIOS over Tcpip. . . . . . . . : Disabled

PS C:\> docker run --network mynat --dns 8.8.4.4 --dns-search github.com microsoft/windowsservercore:1709 ipconfig /all

Windows IP Configuration

   Host Name . . . . . . . . . . . . : ef87f28a77b9
   Primary Dns Suffix  . . . . . . . :
   Node Type . . . . . . . . . . . . : Hybrid
   IP Routing Enabled. . . . . . . . : No
   WINS Proxy Enabled. . . . . . . . : No
   DNS Suffix Search List. . . . . . : github.com

Ethernet adapter vEthernet (Ethernet):

   Connection-specific DNS Suffix  . : localdomain
   Description . . . . . . . . . . . : Hyper-V Virtual Ethernet Adapter #5
   Physical Address. . . . . . . . . : 00-15-5D-BA-30-68
   DHCP Enabled. . . . . . . . . . . : No
   Autoconfiguration Enabled . . . . : Yes
   Link-local IPv6 Address . . . . . : fe80::7dc7:584c:d593:40fd%29(Preferred)
   IPv4 Address. . . . . . . . . . . : 172.8.141.101(Preferred)
   Subnet Mask . . . . . . . . . . . : 255.255.240.0
   Default Gateway . . . . . . . . . : 172.8.128.1
   DNS Servers . . . . . . . . . . . : 8.8.4.4
   NetBIOS over Tcpip. . . . . . . . : Disabled

This fully fixes: moby/moby#30260 , docker/for-win#397 .

Tested-by: Alin Gabriel Serdean [email protected]

LGTM

cc @mavenugo

[fcrisciani]

LGTM

[philipwolfe]

Thanks for this great option!

In Visual Studio, I was not able to set this option in the docker-compose msbuild property <DockerComposeUpArguments>-o com.docker.network.windowsshim.disable_gatewaydns=true</DockerComposeUpArguments>.
But I was able to add it directly in the docker-compose yaml.

version: '3.4'

networks:
  app_net:
    driver_opts:
      com.docker.network.windowsshim.disable_gatewaydns: "true"

Works like a charm and saves me from having to reorder my DNS with the powershell
set-dnsclientserveraddress -interfaceindex xx -serveraddresses ("192.168.0.xx","192.168.0.xx","172.23.0.xx")