-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a new network creation driver option (disable_gatewaydns) for t… #2021
Conversation
…he Windows driver Signed-off-by: Cheng-mean Liu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2021 +/- ##
=========================================
Coverage ? 38.85%
=========================================
Files ? 137
Lines ? 27374
Branches ? 0
=========================================
Hits ? 10637
Misses ? 15439
Partials ? 1298 Continue to review full report at Codecov.
|
LGTM |
Thanks a lot for the patch! It would be nice to mention this change require Windows version 1709 to work.
This fully fixes: moby/moby#30260 , docker/for-win#397 . Tested-by: Alin Gabriel Serdean [email protected] LGTM cc @mavenugo |
LGTM |
Windows fixes: moby/libnetwork#1916 moby/libnetwork#2014 moby/libnetwork#2021 Fix for veth leak on daemon crash Cleanup networkDB logic for node management Signed-off-by: Flavio Crisciani <[email protected]>
Thanks for this great option! In Visual Studio, I was not able to set this option in the docker-compose msbuild property
Works like a charm and saves me from having to reorder my DNS with the powershell |
…he Windows driver
Signed-off-by: Cheng-mean Liu [email protected]
This new disable_gatewaydns option provides a way for a client to create a network instance without any gateway IP added into the DNS list for all of its endpoints.
Usage of disable_gatewaydns:
When set as true, the Windows network driver will skip the addition of the gateway IP into the DNS list.
When not specified, the default setting for disable_gatewaydns is false, that is, it will always add gateway IP into an endpoint's DNS list unless an endpoint was created specifically with an existing epOption.DisableDNS option.
Example usage:
docker network create -d nat --gateway 172.8.128.1 --subnet 172.8.128.0/20 -o com.docker.network.windowsshim.dnsservers=4.4.4.4,8.8.8.8 -o com.docker.network.windowsshim.disable_gatewaydns=true mynat