Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ExtractSmartTagsPlugin example #243

Merged
merged 5 commits into from
Sep 29, 2020
Merged

Add ExtractSmartTagsPlugin example #243

merged 5 commits into from
Sep 29, 2020

Conversation

phryneas
Copy link
Contributor

This is not the most clean example, but it does the job and should be a good starting point.

benjie
benjie approved these changes Sep 29, 2020
View reviewed changes
Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @phryneas 🙌

@benjie
Convert to CommonJS
fa0705b
@benjie
Use module.exports
4d9a571
@benjie
Generate examples using new example
f445a43 
Also added documentation, fixed formatting, and fixed a bug in example
updating where `__dirname` wasn't supported, and where `.json` files
were attempted to be executed as if they were `.js` files.
@benjie
Remove syntax that doesn't work on Node 12
6ceff3b
@benjie benjie changed the title add ExtractSmartTagsPlugin Add ExtractSmartTagsPlugin example Sep 29, 2020
@benjie benjie merged commit 866eb85 into graphile:develop Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjie benjie benjie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phryneas @benjie