Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: news site and footer #365

Merged
merged 10 commits into from
Mar 9, 2023
Merged

update: news site and footer #365

merged 10 commits into from
Mar 9, 2023

Conversation

jemgillam
Copy link
Collaborator

@jemgillam jemgillam commented Mar 8, 2023

A news update for the Grafast talk at GraphQL Galaxy 2022
A news update for the Schema Metadata talk at GraphQL Foundation Conf 2022

plus

  • Fix description of GraphQL Galaxy 2021 article
  • Changes to News site header:
    • RSS link
    • Sponsor link
  • Changes to site-wide footer:
    • Mastodon
    • Youtube
  • Readme states correct node version

@jemgillam
Copy link
Collaborator Author

@benjie hmmmm how should I be linking to the RSS feed? /news/rss.xml is disallowed apparently.

@benjie
Copy link
Member

benjie commented Mar 8, 2023

If you're sure the URL is correct then add xml to this regexp:

} else if (trimmed.match(/\.(css|png|svg|webmanifest)$/)) {
// Resources
return;

@jemgillam
Copy link
Collaborator Author

It now passes the link check!

@jemgillam jemgillam merged commit 77dfb92 into develop Mar 9, 2023
@jemgillam jemgillam deleted the newsupdate branch March 9, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants