Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port GKE import cluster page from Ember to Vue #12408

Closed
mantis-toboggan-md opened this issue Oct 29, 2024 · 1 comment · Fixed by #13447
Closed

Port GKE import cluster page from Ember to Vue #12408

mantis-toboggan-md opened this issue Oct 29, 2024 · 1 comment · Fixed by #13447
Assignees
@mantis-toboggan-md @yonasberhe23
Labels
area/eks ember Ember UI Issue kind/tech-debt Technical debt QA/manual-test Indicates issue requires manually testing size/3 Size Estimate 3
Milestone
v2.11.0

Comments

@mantis-toboggan-md
Copy link
Member

Following on from #8967 we need to port the view shown when initially importing a new GKE cluster. Once the cluster is imported, the existing GKE provisioning form is used.

Screenshot 2024-10-29 at 9 59 40 AM

Screenshot 2024-10-29 at 9 59 53 AM

Screenshot 2024-10-29 at 10 00 08 AM
@mantis-toboggan-md mantis-toboggan-md added kind/tech-debt Technical debt ember Ember UI Issue area/eks QA/manual-test Indicates issue requires manually testing labels Oct 29, 2024
@mantis-toboggan-md mantis-toboggan-md added this to the v2.11.0 milestone Oct 29, 2024
@mantis-toboggan-md mantis-toboggan-md self-assigned this Oct 29, 2024
@nwmac nwmac modified the milestones: v2.12.0, v2.11.0 Nov 1, 2024
@mantis-toboggan-md mantis-toboggan-md mentioned this issue Jan 10, 2025
Closed
@gaktive gaktive added the size/3 Size Estimate 3 label Jan 14, 2025
@mantis-toboggan-md mantis-toboggan-md mentioned this issue Feb 19, 2025
Merged
7 tasks
@yonasberhe23 yonasberhe23 self-assigned this Feb 28, 2025
@yonasberhe23 yonasberhe23 reopened this Feb 28, 2025
This was referenced Feb 28, 2025
Closed
Closed
Closed
Closed
@yonasberhe23
Copy link
Contributor

Tested in:

  • Rancher v2.11-a2ff78325d1768b0a52fa65a88c00a1f3cddace5-head
  • Dashboard master 182233d
  • view shown when initially importing a new GKE cluster has been updated
Image
  • GKE name validators tested with valid and invalid names and we still require unique names for cluster creation
  • able to import gke cluster using zonal/regional options
  • able to edit gke imported cluster

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mantis-toboggan-md mantis-toboggan-md

@yonasberhe23 yonasberhe23

Labels
area/eks ember Ember UI Issue kind/tech-debt Technical debt QA/manual-test Indicates issue requires manually testing size/3 Size Estimate 3
Projects
None yet
Milestone
v2.11.0
Development

Successfully merging a pull request may close this issue.

Import GKE clusters mantis-toboggan-md/dashboard
4 participants
@nwmac @gaktive @mantis-toboggan-md @yonasberhe23