Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix terminal preventing the main section from scrolling #13540

Merged
merged 5 commits into from
Mar 7, 2025

Conversation

momesgin
Copy link
Member

@momesgin momesgin commented Feb 28, 2025

Summary

Fixes #13036

Technical notes summary

It seems Chrome behaves different from other browsers when the position property is absent on an element that's positioned by its parent's grid layout. Adding position: relative; to the terminal element fixed the scrolling conflict.

Areas or cases that should be tested

#5245 should also be checked

Areas which could experience regressions

I've tested the scrolling and the original loading issue on many different pages while having the terminal open. Please do the same with any page you think it might have loading and scrolling capabilities.

Screenshot/Video

t.mov

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@momesgin momesgin added this to the v2.11.0 milestone Feb 28, 2025
@momesgin momesgin requested a review from richard-cox February 28, 2025 00:39
@momesgin momesgin self-assigned this Feb 28, 2025
@momesgin momesgin requested a review from richard-cox March 4, 2025 00:48
Copy link
Member

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good, however someone who can reproduce the bug should also take a look (i couldn't on linux + chrome)

Copy link
Contributor

@codyrancher codyrancher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified. Working on my end.

@momesgin momesgin dismissed richard-cox’s stale review March 7, 2025 18:08

it's been already mentioned that the change looks good, it was only waiting for another confirmation to see if the fix works, and Cody confirmed.

@momesgin momesgin merged commit 38c88d6 into rancher:master Mar 7, 2025
35 checks passed
@momesgin momesgin deleted the 13036-terminal-overlay branch March 7, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opening the shell blocks scrolling on the explorer pages
3 participants