Fix terminal preventing the main section from scrolling #13540
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #13036
Technical notes summary
It seems Chrome behaves different from other browsers when the position property is absent on an element that's positioned by its parent's grid layout. Adding
position: relative;
to the terminal element fixed the scrolling conflict.Areas or cases that should be tested
#5245 should also be checked
Areas which could experience regressions
I've tested the scrolling and the original loading issue on many different pages while having the terminal open. Please do the same with any page you think it might have loading and scrolling capabilities.
Screenshot/Video
t.mov
Checklist