Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jenkins percy configuration #13632

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

a-arias
Copy link
Contributor

@a-arias a-arias commented Mar 6, 2025

Summary

Adds ability to run visual tests on CI and send build to percy dashboard.

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
Siteproxy
@a-arias a-arias force-pushed the jenkins_percy_configuration branch from 0e3165b to 2b025bb Compare March 6, 2025 21:46
@a-arias a-arias force-pushed the jenkins_percy_configuration branch from 75e2fe7 to c5c19f4 Compare March 6, 2025 21:55
@izaac izaac requested review from IsaSih, izaac and yonasberhe23 March 6, 2025 21:56
@izaac
Copy link
Contributor

izaac commented Mar 6, 2025

Dep: rancherlabs/corral-packages#74

Copy link
Contributor

@yonasberhe23 yonasberhe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so I'll go ahead and approve. But I we may need to backport these changes to older dashboard release branches so we don't run into issues with Jenkins recurring runs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants