Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed error shown in console when importing GKE #13671

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

eva-vashkevich
Copy link
Member

@eva-vashkevich eva-vashkevich commented Mar 10, 2025

Summary

Fixes #13562

Moved nodePools configuration to non-imported block, since cluster import doesn't need it and doesn't have them defined

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

  • Import GKE -> select credential -> no error should be shown in the console
  • Edit imported GKE -> no error should be shown in the console
  • Create GKE -> no error should be shown in the console
  • Edit existing GKE -> no error should be shown in the console

Areas which could experience regressions

GKE provisioning and import (both create and edit)

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

Copy link
Member

@momesgin momesgin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and lgtm

@eva-vashkevich eva-vashkevich merged commit 6ac0c0f into rancher:master Mar 11, 2025
47 of 48 checks passed
@eva-vashkevich eva-vashkevich deleted the iss13562 branch March 11, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GKE: Import: Console error thrown when landing on the GKE credentials page
2 participants