Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/13670 pages data #13672

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

rak-phillip
Copy link
Member

Summary

Fixes #13670

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@@ -188,6 +186,10 @@ export default {
...mapGetters(['currentCluster']),
...monitoringStatus(),

clusterCounts() {
return this.$store.getters[`cluster/all`](COUNT);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

counts churn a LOT

is there any difference between a reactive object from store on data and returning that same object as a computed? if not this is fine, if so it would need be outside of a computed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using computed properties is the most common way to interface with vuex getters.

Results of computed properties are cached based on their reactive dependencies and vuex getters behave largely in the same way. Because of this similarity, the computed property should react to changes only if the getter returns a new value. Otherwise, the cached result is used when attempting to access the computed property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data Exceptions: Pages
2 participants