-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/13670 pages data #13672
base: master
Are you sure you want to change the base?
Bugfix/13670 pages data #13672
Conversation
Signed-off-by: Phillip Rak <[email protected]>
Signed-off-by: Phillip Rak <[email protected]>
Signed-off-by: Phillip Rak <[email protected]>
Signed-off-by: Phillip Rak <[email protected]>
Signed-off-by: Phillip Rak <[email protected]>
@@ -188,6 +186,10 @@ export default { | |||
...mapGetters(['currentCluster']), | |||
...monitoringStatus(), | |||
|
|||
clusterCounts() { | |||
return this.$store.getters[`cluster/all`](COUNT); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
counts
churn a LOT
is there any difference between a reactive object from store on data
and returning that same object as a computed? if not this is fine, if so it would need be outside of a computed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using computed properties is the most common way to interface with vuex getters.
Results of computed properties are cached based on their reactive dependencies and vuex getters behave largely in the same way. Because of this similarity, the computed property should react to changes only if the getter returns a new value. Otherwise, the cached result is used when attempting to access the computed property.
Summary
Fixes #13670
Occurred changes and/or fixed issues
Technical notes summary
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video
Checklist