Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Cluster - Cannot properly edit RKE cluster as cluster owner when admin created the cluster #22080

Closed
davidnuzik opened this issue Aug 8, 2019 · 5 comments
Assignees
Labels
area/api kind/bug-qa Issues that have not yet hit a real release. Bugs introduced by a new feature or enhancement status/blocker
Milestone

Comments

@davidnuzik
Copy link
Contributor

Similar issue: #12038

Version: master-head (v2.3) (8/8/19)

What kind of request is this (question/bug/enhancement/feature request):
Bug

Steps and results:

  • Create a cluster (without CT) as an admin. Make a user "test1" a cluster owner.
  • Log in as the "test1" user, try to edit the Cluster. Rancher UI thinks it's a custom cluster so they can't properly edit the cluster.
    image
  • Create another cluster (this time with a simple CT) as an admin. Make user "test1" a cluster owner.
  • Log in as the "test1" user, try to edit the Cluster. We have access to the cluster template (even though we did not share the CT) per [UI] Cluster Templates - Not allowed to edit cluster as an added cluster owner (who does not have access to cluster template) #21473 so we don't need to be shared the CT.
    Same issue, "test1" user sees cluster as custom and when edits cluster gets "Custom" cluster UI for editing (asking to chose roles and update nodes with new commandline).
@davidnuzik davidnuzik added area/ui kind/bug-qa Issues that have not yet hit a real release. Bugs introduced by a new feature or enhancement team/ui labels Aug 8, 2019
@davidnuzik davidnuzik self-assigned this Aug 8, 2019
@deniseschannon deniseschannon added this to the v2.3 milestone Aug 8, 2019
@westlywright
Copy link
Contributor

I made a fix here that changed this but forgot that the previous view was deemed acceptable in 2.2. I will revert this change to get us back to the old behavior.

In order to fix this whole custom thing we need a way for either the node-template to be shared or at the very least a way to figure out what provider the cluster is on without access to the nodes.

@westlywright westlywright self-assigned this Aug 9, 2019
@davidnuzik davidnuzik changed the title [UI] Cluster - Cannot RKE cluster as cluster owner when admin created the cluster [UI] Cluster - Cannot properly edit RKE cluster as cluster owner when admin created the cluster Aug 9, 2019
@zube zube bot removed the [zube]: Peer Review label Aug 9, 2019
@davidnuzik
Copy link
Contributor Author

Version: master-head (v2.3) (8/12/19)

Still not quite right, the revert was an attempt to let us have the workaround in #12038 where we pick the rke cluster and can then edit properly. The main issue is we don't have access to the node template, which is a known issue. The past way we could from the UI pick what kind of rke cluster it is and then edit properly.

When I log in as the "test1" user and try to edit the cluster I just see a blank page now:
image

@vincent99
Copy link
Contributor

@cjellick Can I get the nodeTemplate->driver copied onto the nodePool so this can be improved instead of just reimplementing the asking for what driver to use thing we had in 2.2?

@vincent99 vincent99 added the status/awaiting-backend Indicates a UI issue is waiting for a backend change to be merged before UI work can proceed label Aug 19, 2019
@cjellick cjellick self-assigned this Aug 30, 2019
@cjellick cjellick removed the team/ui label Aug 30, 2019
@cjellick cjellick removed their assignment Aug 30, 2019
vincent99 added a commit to rancher/ui that referenced this issue Aug 30, 2019
Edit clusters using node templates you can't see (rancher/rancher#22080)
@cbron cbron removed the status/awaiting-backend Indicates a UI issue is waiting for a backend change to be merged before UI work can proceed label Aug 30, 2019
@cbron
Copy link
Contributor

cbron commented Aug 30, 2019

Backend PR merged to master.

@davidnuzik
Copy link
Contributor Author

Version: master-head (v2.3) (9/3/19)

I tested both scenarios. I didn't identify any issues.

Scenario 1:
Create a cluster (without using a template).

  • Make sure you add "test1" user as a cluster owner
  • Log in as "test1" user and edit the cluster - we now are able to edit without any issues.
  • Change something and ensure the change takes and the cluster updates accordingly.
  • Smoke test to ensure the cluster is still in a good state and usable.

Scenario 2:
Same steps as above, except create the CT as admin and create the cluster with this CT as admin.
Make sure to add "test1" user as a cluster owner and test editing again.

In both scenarios this now works without any issues. The "test1" cluster owner user is able to edit a cluster whether or not it was created with a CT without any issues.

@zube zube bot removed the [zube]: Done label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api kind/bug-qa Issues that have not yet hit a real release. Bugs introduced by a new feature or enhancement status/blocker
Projects
None yet
Development

No branches or pull requests

7 participants