-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI] Cluster - Cannot properly edit RKE cluster as cluster owner when admin created the cluster #22080
Comments
I made a fix here that changed this but forgot that the previous view was deemed acceptable in 2.2. I will revert this change to get us back to the old behavior. In order to fix this whole custom thing we need a way for either the node-template to be shared or at the very least a way to figure out what provider the cluster is on without access to the nodes. |
Version: master-head (v2.3) (8/12/19) Still not quite right, the revert was an attempt to let us have the workaround in #12038 where we pick the rke cluster and can then edit properly. The main issue is we don't have access to the node template, which is a known issue. The past way we could from the UI pick what kind of rke cluster it is and then edit properly. When I log in as the "test1" user and try to edit the cluster I just see a blank page now: |
@cjellick Can I get the nodeTemplate->driver copied onto the nodePool so this can be improved instead of just reimplementing the asking for what driver to use thing we had in 2.2? |
Edit clusters using node templates you can't see (rancher/rancher#22080)
Backend PR merged to master. |
Version: master-head (v2.3) (9/3/19) I tested both scenarios. I didn't identify any issues. Scenario 1:
Scenario 2: In both scenarios this now works without any issues. The "test1" cluster owner user is able to edit a cluster whether or not it was created with a CT without any issues. |
Similar issue: #12038
Version: master-head (v2.3) (8/8/19)
What kind of request is this (question/bug/enhancement/feature request):
Bug
Steps and results:
Same issue, "test1" user sees cluster as custom and when edits cluster gets "Custom" cluster UI for editing (asking to chose roles and update nodes with new commandline).
The text was updated successfully, but these errors were encountered: