Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Xcode 11.0 beta 5 #123

Merged
merged 2 commits into from
Sep 11, 2019
Merged

Update for Xcode 11.0 beta 5 #123

merged 2 commits into from
Sep 11, 2019

Conversation

erikbasargin
Copy link
Contributor

Hello! 👋
An error appears when building in Xcode 11:

Command CompileXIB failed with a nonzero exit code

This problem was solved by removing customModuleProvider (i.e. Inherit Module From Target) for cells in xib files. 🤗

@BSFishy
Copy link

BSFishy commented Aug 9, 2019

Thanks for the fix! This worked for me.

@lakecountypassage
Copy link

I didn't use your commit, but I manually changed the file in XCode and it worked, thank you! It would be nice to have this merged before iOS13 is released

@eastsss
Copy link

eastsss commented Aug 27, 2019

can we have this merged? this is critical because it's impossible to compile the pod without these changes if you use Xcode 11

@jimmyhoran
Copy link

can we have this merged? this is critical because it's impossible to compile the pod without these changes if you use Xcode 11

Agreed. Would be great to get this fix merged in.
Anybody able to provide an indication of when this is likely to be merged?

@codingrhythm
Copy link

Yeah, we really need to get this merged for iOS 13 release.

@cassianodialpad
Copy link

@mtnbarreto up! =)

@mats-claassen mats-claassen merged commit e26395b into xmartlabs:master Sep 11, 2019
@erikbasargin
Copy link
Contributor Author

@mats-claassen thank you! 😜
Maybe you should upgrade to 5.0.1? So it will be more beautiful in podfile. 🤗

@cassianodialpad
Copy link

@mats-claassen thank you! 😜
Maybe you should upgrade to 5.0.1? So it will be more beautiful in podfile. 🤗

Yes, can we have a new tag please? @mats-claassen
Thanks a lot for merging this! =)

@mats-claassen
Copy link
Member

Let's wait for the definitive Xcode 11 to come out before making a release just in case something changes. Until then master branch should be enough

@erikbasargin
Copy link
Contributor Author

@mats-claassen Well, the "Xcode 11 GM Seed" is already released. It usually doesn't change much 🙃There are usually only bug fixes 🤷🏿‍♂️
However, here you have to make a decision 😊

@cassianodialpad
Copy link

For extra information: I've tested it with XCode 11 GM seed, works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants