Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPM Support #144

Merged
merged 1 commit into from
Feb 8, 2021
Merged

SPM Support #144

merged 1 commit into from
Feb 8, 2021

Conversation

andrew-muzz
Copy link
Contributor

No description provided.

.library(name: "XLActionController", targets: ["XLActionController"])
],
targets: [
.target(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't had a deeper look into what SPM supports but would it be possible to support multiple subtargets? (as in Cocoapods there are subspecs)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah you can support multiple targets with SPM. I'm no SPM expert but RxSwift are a good example of this here.

I didn't do it here as I didn't need it to consume this library in my project. Happy to change for this PR though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to be consistent with how the cocoapods subspecs are set up

@mats-claassen
Copy link
Member

Hi @andrew-muzmatch could you rebase this on top of master? If you can also add the sub targets great otherwise we can handle it

@mats-claassen mats-claassen merged commit 12b5cd2 into xmartlabs:master Feb 8, 2021
@andrew-muzz
Copy link
Contributor Author

Hi @mats-claassen , sorry been a very busy day and only just saw your message. Thanks for getting it merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants