-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Trigger.dev and jobs #846
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your pull request is detected by Liam Migration. 8 files are changed. |
7b381e7
to
4ccfb67
Compare
- - :approve | ||
- "@electric-sql/client" | ||
- :who: OSPO @masutaka | ||
:why: The license is Apache-2.0. | ||
:versions: [] | ||
:when: 2025-03-11 06:08:23.596952 Z |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import * as dotenv from 'dotenv' | ||
|
||
dotenv.config() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without dotenv
, the environment variable seemed to be undefind
.🙏
(When running pnpm trigger:dev
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my local shell environment, process.env.TRIGGER_PROJECT_ID
is still undefined. 🤔
Do you use any shell tool or plugin? Maybe VSCode?
Anyway, I verified that by setting up some workarounds, I can use the dev and deploy commands from my environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I understood. Linking .env.develop to .env solves.
# example
ln -s .env.development .env
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'm using .env
!
PR Code Suggestions ✨Explore these optional code suggestions:
|
Let me check! 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Please check package.json 🙏🏻
frontend/apps/app/package.json
Outdated
@@ -41,6 +43,7 @@ | |||
"lint:biome": "biome check .", | |||
"postinstall": "cp ../../packages/db-structure/node_modules/@ruby/prism/src/prism.wasm prism.wasm", | |||
"start": "next start", | |||
"trigger:dev": "pnpm dlx trigger.dev@latest dev", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fix it so that pnpm dev
can start the dev server at once?
"trigger:dev": "pnpm dlx trigger.dev@latest dev", | |
"dev:trigger": "pnpm dlx trigger.dev@latest dev", |
frontend/apps/app/package.json
Outdated
@@ -41,6 +43,7 @@ | |||
"lint:biome": "biome check .", | |||
"postinstall": "cp ../../packages/db-structure/node_modules/@ruby/prism/src/prism.wasm prism.wasm", | |||
"start": "next start", | |||
"trigger:dev": "pnpm dlx trigger.dev@latest dev", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to add to devDependencies, and fix to the following:
"trigger:dev": "pnpm dlx trigger.dev@latest dev", | |
"trigger:dev": "trigger.dev dev", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for letting me know!
I added trigger.dev
to devDependencies. (21b1d8b)
But Dependency Review test faild because trigger.dev depends on [email protected]
So, I added resolutions
to package.json
because trigger.dev
depends on [email protected]
.
Is that OK?🙏
21b1d8b ... add resolutions
89e715e ... change packageManager
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see! I think resolutions
is correct approach .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for confirming!😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Confirmed:
$ pnpm trigger:dev
in thefrontend/apps/app
directory.$ pnpm dlx trigger.dev@latest deploy
in thefrontend/apps/app
directory.
Dependency ReviewThe following issues were found:
|
CI Feedback 🧐(Feedback updated until commit 51dffe0)A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
Issue
Trigger.dev as a job worker.
Concrete job images are added to
frontend/apps/app/src/trigger/jobs.ts
.https://github.com/liam-hq/liam/pull/846/files#diff-f59dcca9048641d0588315ab628cc432c0f9b951059a5318eacd7166e3692bd3
I think the starting point of the job is the webhook in
/app/api/webhook/github/route.ts
, but I have not added any code there. I am thinking that the code will probably be as followsWhy is this change needed?
What would you like reviewers to focus on?
Testing Verification
What was done
🤖 Generated by PR Agent at ad3119b
savePullRequestTask
,generateReviewTask
,saveReviewTask
, andpostCommentTask
.@trigger.dev/sdk
,dotenv
, and other supporting libraries.TRIGGER_PROJECT_ID
for Trigger.dev project configuration.Detailed Changes
jobs.ts
Added task-based workflow for pull request processing.
frontend/apps/app/src/trigger/jobs.ts
savePullRequestTask
,generateReviewTask
,saveReviewTask
, andpostCommentTask
.specific payloads.
generating and saving reviews.
requests.
trigger.config.ts
Added Trigger.dev configuration file for task management.
frontend/apps/app/trigger.config.ts
defineConfig
.package.json
Updated package.json with Trigger.dev dependencies and scripts.
frontend/apps/app/package.json
@trigger.dev/sdk
anddotenv
to dependencies.trigger:dev
for Trigger.dev development..env.development
Added environment variable for Trigger.dev project configuration.
frontend/apps/app/.env.development
TRIGGER_PROJECT_ID
for Trigger.dev.pnpm-lock.yaml
Updated dependencies for Trigger.dev integration.
pnpm-lock.yaml
@trigger.dev/sdk
and related packages.dotenv
and other supporting libraries.dependency_decisions.yml
Approved new dependency for Trigger.dev integration.
config/dependency_decisions.yml
@electric-sql/client
with an Apache-2.0 license.packages-license.md
Updated package license documentation with new entries and
adjustments.
docs/packages-license.md
2.0, and New BSD.
@electric-sql/client
,@google-cloud/precise-date
, and others.@opentelemetry/api-logs
andzod
.license types and approval statuses.
Additional Notes