Add processSavePullRequest function and integrate it into the savePullRequestTask #869
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Updates to Preview Branch (save-function-1) ↗︎
Tasks are run on every commit but only new migration files are pushed.
View logs for this Workflow Run ↗︎. |
eecb9fb to
796b003
Compare
796b003 to
0be2f94
Compare
0be2f94 to
63cd83e
Compare
CI Feedback 🧐(Feedback updated until commit 21fe4c6)A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
63cd83e to
40652b6
Compare
40652b6 to
d991103
Compare
d991103 to
fe52406
Compare
fe52406 to
21fe4c6
Compare
21fe4c6 to
a9071cb
Compare
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
||||||||||||||
| } | ||
|
|
||
| const data = JSON.parse(payload) as GitHubWebhookPayload | ||
| validateConfig() |
There was a problem hiding this comment.
This line is unnecessary, because Because it is done at server startup.
There was a problem hiding this comment.
I'll fix that in this week 🙏
| @@ -6,6 +6,7 @@ import { | |||
| import type { GitHubWebhookPayload } from '@/types/github' | |||
| import { prisma } from '@liam-hq/db' | |||
|
|
|||
| // deprecated | |||
| owner: payload.owner, | ||
| name: payload.name, | ||
| repositoryId: payload.repositoryId, | ||
| } as SavePullRequestPayload) |
There was a problem hiding this comment.
Please do not use as if possible. Was it necessary?
There was a problem hiding this comment.
Unnecessary. Applying #869 (comment) will solve that. 🙏
There was a problem hiding this comment.
Regarding the conflict in this pull request and the lengthy Vercel deployment, I'll address these issues in a separate PR. 🙏
| try { | ||
| const result = await processSavePullRequest({ | ||
| prNumber: payload.pullRequestNumber, | ||
| owner: payload.owner, | ||
| name: payload.name, | ||
| repositoryId: payload.repositoryId, | ||
| } as SavePullRequestPayload) | ||
| logger.info('Successfully saved PR to database:', { prId: result.prId }) | ||
|
|
||
| // Trigger the next task in the chain - generate review | ||
| await generateReviewTask.trigger({ | ||
| ...payload, | ||
| projectId: undefined, | ||
| schemaChanges: result.schemaChanges, | ||
| } as GenerateReviewPayload) | ||
|
|
||
| return result | ||
| } catch (error) { | ||
| logger.error('Error in savePullRequest task:', { error }) | ||
| throw error | ||
| } |
There was a problem hiding this comment.
📝
Save the pull request details to the database, then trigger the review generation.
| switch (action) { | ||
| case 'opened': | ||
| case 'synchronize': | ||
| case 'reopened': { | ||
| // Queue the savePullRequest task | ||
| await savePullRequestTask.trigger({ | ||
| pullRequestNumber: pullRequest.number, | ||
| projectId: undefined, | ||
| owner: data.repository.owner.login, | ||
| name: data.repository.name, | ||
| repositoryId: data.repository.id, | ||
| }) |
There was a problem hiding this comment.
📝
Trigger savePullRequestTask when a pull request is opened, synchronized, or reopened.
There was a problem hiding this comment.
📝
Check if the corresponding repository exists in the database, retrieve the PR's modified files, analyze the changed files, save them to the database, and return the PR data for the next process.
Issue
Why is this change needed?
What would you like reviewers to focus on?
Testing Verification
What was done
🤖 Generated by PR Agent at a9071cb
processSavePullRequestfunction for PR data handling.savePullRequestTaskwith webhook and database operations.Detailed Changes
6 files
Refactor webhook handling and integrate PR save taskExtend file change handling with detailed statusesAdd `processSavePullRequest` function for PR data processingIntegrate `processSavePullRequest` into `savePullRequestTask`Update types to support optional projectIdEnhance `FileChange` type with detailed statuses and patch2 files
Mark `handlePullRequest` as deprecatedDocument updated PR save and review workflowAdditional Notes