Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening the shell blocks scrolling on the explorer pages #13036

Closed
momesgin opened this issue Jan 9, 2025 · 6 comments · Fixed by #13540
Closed

Opening the shell blocks scrolling on the explorer pages #13036

momesgin opened this issue Jan 9, 2025 · 6 comments · Fixed by #13540
Assignees
Labels
kind/bug priority/0 QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this QA/manual-test Indicates issue requires manually testing status/backport-candidate
Milestone

Comments

@momesgin
Copy link
Member

momesgin commented Jan 9, 2025

Setup

  • Rancher version: 2.10
  • Rancher UI Extensions:
  • Browser type & version:

Describe the bug

Opening the shell blocks scrolling on the explorer pages

To Reproduce

Go to Explorer page => Open kubectl shell from the top navbar or press Ctrl+` => Try scrolling on the page

Result

Scrolling doesn't work

Expected Result

Scrolling should work

Screenshots

image

Additional context

@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Jan 9, 2025
@momesgin momesgin changed the title Opening the shell block scrolling on the explorer pages Opening the shell blocks scrolling on the explorer pages Jan 9, 2025
@gaktive gaktive added this to the v2.11.0 milestone Jan 9, 2025
@richard-cox
Copy link
Member

I couldn't reproduce this on our latest build (master 23c0cdb).

  • shell open
  • vertical scroll bars visible in the resource menu and main content area
  • for both scroll area i could scroll using
    • manual use of scroll bar using mouse
    • cursor mouse over and mouse wheel scroll.

I'm using Chrome Version 131.0.6778.264 (Official Build) (64-bit)

@momesgin Could this be a browser thing? What rancher version, and ui build/commit were you using? Could you expand on what you mean by "Scrolling doesn't work"?

@momesgin
Copy link
Member Author

momesgin commented Jan 13, 2025

@richard-cox I can repro this locally on the latest master, but only in Chrome(my version: 131.0.6778.140 - Official Build - arm64). Safari and Firefox seem to be working fine.

It's the vertical scrolling that doesn't work as soon as you open the shell.

scroll.mov

In the recording, I'm trying to scroll vertically after opening the shell.

Version:
image

Same issue with the latest Chrome Version 131.0.6778.265 (Official Build) (arm64)

@codyrancher
Copy link
Contributor

Just for some additional insight,

I was only able to reproduce this in chrome. Interestingly, when I first open the terminal I can continue to scroll without issue. However, after the terminal connects I'm no longer able to scroll even if I close the terminal and open a brand new.

@momesgin
Copy link
Member Author

It seems the root cause is having a z-index of 13(windowsManager: 13) on the terminal element that was added to fix another overlay issue by this PR. Whoever picks this up should make sure both issues are fixed in the end.

@yonasberhe23
Copy link
Contributor

Manual validation required. automation task created rancher/qa-tasks#1721

@yonasberhe23 yonasberhe23 added the QA/manual-test Indicates issue requires manually testing label Mar 9, 2025
@izaac izaac self-assigned this Mar 10, 2025
@izaac
Copy link
Contributor

izaac commented Mar 10, 2025

Rancher version: v2.11-af56e7fa886d35cb2f464422389c4a57e2f65a17-head
UI version: master 0c04865
Chrome: 133.0.6943.143

Scrolling with a shell opened is working as expected in this Rancher/UI build.
Navigating with the keyboard works too.

@izaac izaac closed this as completed Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug priority/0 QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this QA/manual-test Indicates issue requires manually testing status/backport-candidate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants